Better photos#1085
Merged
Merged
Conversation
Deploying falling-fruit-web with
|
| Latest commit: |
2debc8d
|
| Status: | ⚡️ Build in progress... |
Collaborator
|
@wbazant To match the legacy website, the new API produces three sizes: 100 px (thumb), 300 px (medium), 2048 px ("original"), which are uploaded to Amazon S3. So 2048 px would be a reasonable max size for the frontend. Did you feel that 0.8 → 0.85 was worth it? The reason the medium often looks fuzzy in the drawer/sidebar is that these are often wider (average width for phones nowadays is ~400 px) and, if the image is vertical, it is 300 px tall so quite a bit less than 300 px wide. |
Collaborator
Author
I've not tried to compare on compression quality, just took a chatgpt recommendation. We can go with just the max width change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1080
I've assembled an experimental setup of objects of varying colors in diffuse lighting, took two pictures, and uploaded: https://falling-fruit-web.pages.dev/locations/1989825/@55.8258624,-4.2610278,18z .
I can tell the better one from the lighting on the window frame for example. Sizes are 162kb and 460kb, so still the same ballpark - I think the slow uploads I originally tried to fix were from pictures weighing a few megabytes. Agreeing with you @ezwelty that the resizing was too aggressive, thanks for pointing it out!